feat: enable rules_python Starlark implemention by default for Bazel 7+#1699
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Feb 13, 2024
Merged
Conversation
rickeylev
force-pushed
the
pystar.enabled.by.default
branch
2 times, most recently
from
e7481b1 to
779f050
Compare
This makes the base rules use the Starlark code in rules_python
("pystar") instead of what is built into Bazel 7.
The pystar implementation can be disabled by setting
`RULES_PYTHON_ENABLE_PYSTAR=0` in your environment or using
`--action_env`.
Earlier versions of Bazel continue to use the rules built into Bazel
regardless (the new implementation requires special APIs that only Bazel
7 has).
Work towards bazel-contrib#1069
rickeylev
force-pushed
the
pystar.enabled.by.default
branch
from
779f050 to
c0880bf
Compare
Collaborator
Author
|
Doh, forgot the changelog entry |
aignas
approved these changes
Jan 23, 2024
Collaborator
Author
|
posterity, from maintainer's meeting: The plan for this PR is to make it its own release. So immediately after the next release, I'll merge this and then do a subsequent release. This is to help decouple it from the other fixes/features/breaking-changes that have been going in. I'm not too worried about regressions (Bazel 7 uses the new starlark impl this is based upon; Google has been using the starlark impl for many months and the rules_python variant for several weeks), but I'd rather be more cautious in this particular case. |
…on into pystar.enabled.by.default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the base rules use the Starlark code in rules_python
("pystar") instead of what is built into Bazel 7.
The pystar implementation can be disabled by setting
RULES_PYTHON_ENABLE_PYSTAR=0in your environment or using--action_env.Earlier versions of Bazel continue to use the rules built into Bazel
regardless (the new implementation requires special APIs that only Bazel
7 has).
Work towards #1069